chore

flarum · Nov 8, 2024 · 087c00a · 087c00a
1 parent 2362bc7
commit 087c00a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/framework/core/js/src/forum/components/GlobalSearch.tsx b/framework/core/js/src/forum/components/GlobalSearch.tsx
@@ -4,13 +4,15 @@ import GlobalDiscussionsSearchSource from './GlobalDiscussionsSearchSource';
 import GlobalUsersSearchSource from './GlobalUsersSearchSource';
 import GlobalPostsSearchSource from './GlobalPostsSearchSource';
 import AbstractGlobalSearch, {
-  type SearchAttrs,
+  type SearchAttrs as BaseSearchAttrs,
   type GlobalSearchSource as BaseGlobalSearchSource,
 } from '../../common/components/AbstractGlobalSearch';
 
 export interface GlobalSearchSource extends BaseGlobalSearchSource {}
 
-export default class GlobalSearch extends AbstractGlobalSearch {
+export interface SearchAttrs extends BaseSearchAttrs {}
+
+export default class GlobalSearch<Attrs extends SearchAttrs = SearchAttrs> extends AbstractGlobalSearch<Attrs> {
   static initAttrs(attrs: SearchAttrs) {
     attrs.label = app.translator.trans('core.forum.header.search_placeholder', {}, true);
     attrs.a11yRoleLabel = app.translator.trans('core.forum.header.search_role_label', {}, true);

diff --git a/framework/core/js/src/forum/components/Search.tsx b/framework/core/js/src/forum/components/Search.tsx
@@ -41,6 +41,10 @@ export interface SearchAttrs extends ComponentAttrs {
 }
 
 /**
+ * @todo: 2.0 refactored the global search UI and no longer uses this component
+ *        The component was kept to support extension usage of it on a local scope.
+ *        We need to extract this component into a separate UI package instead as it is no longer needed by core.
+ *
  * The `Search` component displays a menu of as-you-type results from a variety
  * of sources.
  *