fix: reset save button state on failure in admin page (#4010)

flarum · Sep 20, 2024 · aafc615 · aafc615
1 parent f13a1c8
commit aafc615
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/framework/core/js/src/admin/components/AdminPage.tsx b/framework/core/js/src/admin/components/AdminPage.tsx
@@ -180,6 +180,13 @@ export default abstract class AdminPage<CustomAttrs extends IPageAttrs = IPageAt
     app.alerts.show({ type: 'success' }, app.translator.trans('core.admin.settings.saved_message'));
   }
 
+  /**
+   * Called when `saveSettings` fails to complete.
+   */
+  onsavefailed(): void {
+    this.loading = false;
+  }
+
   /**
    * Returns a function that fetches the setting from the `app` global.
    */
@@ -232,7 +239,8 @@ export default abstract class AdminPage<CustomAttrs extends IPageAttrs = IPageAt
           app.modal.show(LoadingModal);
           window.location.reload();
         }
-      });
+      })
+      .catch(this.onsavefailed.bind(this));
   }
 
   modelLocale(): Record<string, string> {