fix(regression): discussion creation fails

flarum · Nov 4, 2024 · ffea0db · ffea0db
1 parent b3a4011
commit ffea0db
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/framework/core/src/Api/Resource/DiscussionResource.php b/framework/core/src/Api/Resource/DiscussionResource.php
@@ -240,7 +240,7 @@ public function sorts(): array
     /** @param Discussion $model */
     public function creating(object $model, \Tobyz\JsonApiServer\Context $context): ?object
     {
-        return Discussion::start(null, $context->getActor());
+        return Discussion::start(null, $context->getActor(), $model);
     }
 
     /** @param Discussion $model */

diff --git a/framework/core/src/Discussion/Discussion.php b/framework/core/src/Discussion/Discussion.php
@@ -117,13 +117,9 @@ public static function boot()
     /**
      * Start a new discussion. Raises the DiscussionWasStarted event.
      */
-    public static function start(?string $title, User $user): static
+    public static function start(?string $title, User $user, self $model = null): static
     {
-        $discussion = new static;
-
-        if ($title) {
-            $discussion->title = $title;
-        }
+        $discussion = $model ?? new static;
 
         $discussion->created_at = Carbon::now();
         $discussion->user_id = $user->id;