-
-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Content for User page, preload user & throw 404 accordingly #1901
Conversation
Doesn't add a no-JS view
5ffa330
to
06e7871
Compare
[ci skip] [skip ci]
Applied some changes and added a check for user ID instead of just the username when preloading. Do we want to throw |
Agreed. The model is not found, so we should use that exception. |
@franzliedke Switched exception thrown 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, thank you!
Fixes #1846
Changes proposed in this pull request:
preloadedApiDocument()
call adds it to the forum payloadReviewers should focus on:
Doesn't add a no-JS view. I assume we want one, not sure about what items to include though. Posts/discussions would be hard, and require backend handling of those routes as well.
Screenshot
Confirmed
composer test
).