-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[A11Y] Add focus traps to modals and nav drawer #3018
Conversation
42eb187
to
b1d68e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested locally, but code looks good aside from a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't mean to approve.
2790899
to
4f19eab
Compare
YOU WILL GET CO-AUTHORSHIP OF THAT COMMIT IF IT IS THE LAST THING I DO |
Rebase in progress... @datitisev you still have "requested changes" marked on this PR -- I think I addressed your comment about a breaking change, but I'll re-request your review and you can either approve, dismiss the request, or request other changes. |
Fixes issue where focus trap would remain on the drawer when it is just the app header, if the drawer was opened then the window was made larger.
Co-authored-by: David Sevilla Martin <[email protected]>
4f19eab
to
23a03eb
Compare
Fixes #2663
Fixes #2665
Changes proposed in this pull request:
$.click()
->$.on('click')
)requestAnimationFrame
instead ofsetTimeout
Reviewers should focus on:
Screenshot
Confirmed