Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: convert core modals to TypeScript #3515

Merged
merged 3 commits into from
Jul 13, 2022
Merged

refactor: convert core modals to TypeScript #3515

merged 3 commits into from
Jul 13, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jul 10, 2022 •
edited
Loading

Part of #3533

Changes proposed in this pull request:
Converts all JS modals to TypeScript.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 added this to the 1.5 milestone Jul 10, 2022
@SychO9 SychO9 requested a review from davwheat July 10, 2022 14:03
@SychO9 SychO9 self-assigned this Jul 10, 2022
@SychO9 SychO9 merged commit 1af506d into main Jul 13, 2022
@SychO9 SychO9 deleted the sm/modals-typescript branch July 13, 2022 20:42
@luceos luceos mentioned this pull request Jul 30, 2022
Closed
@luceos luceos mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

Assignees

@SychO9 SychO9

Labels
None yet
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@SychO9 @davwheat