Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dispatch event to flarum/installation-packages on release #3625

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Sep 2, 2022

Changes proposed in this pull request:
Auto trigger build of installation packages on flarum/installation-packages.

  • Needs a PACKAGES_BUILD_TOKEN secret added first. The token must have permission to trigger the workfow_dispatch event on the target repository.
  • Then needs to be tested.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@luceos
Copy link
Member

luceos commented Sep 2, 2022

Is the idea behind your workflow to run after the release, cq the version has been tagged? Because the prepare release workflow only gathers changes, commits, contributors and donators. It doesn't actually tag (yet) because tags need changelogs..

@SychO9
Copy link
Member Author

SychO9 commented Sep 2, 2022

Argh.. true, you run the prepare release workflow first, then tag.

That's fine we can always trigger the tarball build manually as well.

@SychO9 SychO9 closed this Sep 2, 2022
@SychO9 SychO9 deleted the sm/dispatch-installation-package-build-workflow-onrelease branch September 2, 2022 11:32
@SychO9 SychO9 restored the sm/dispatch-installation-package-build-workflow-onrelease branch September 2, 2022 11:35
@SychO9
Copy link
Member Author

SychO9 commented Sep 2, 2022

Actually, let me just switch to a separate workflow that runs on release

@SychO9 SychO9 reopened this Sep 2, 2022
SychO9 and others added 2 commits September 2, 2022 12:54
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9 SychO9 linked an issue Sep 2, 2022 that may be closed by this pull request
@SychO9 SychO9 self-assigned this Sep 2, 2022
@imorland imorland added this to the 2.0 milestone Apr 19, 2023
@SychO9 SychO9 changed the base branch from main to 2.x May 27, 2023 17:42
@SychO9 SychO9 removed this from the 2.0 milestone May 31, 2023
@SychO9 SychO9 added this to the 2.0 milestone Jan 19, 2024
@SychO9 SychO9 marked this pull request as ready for review January 19, 2024 08:54
@SychO9 SychO9 requested a review from a team as a code owner January 19, 2024 08:54
@SychO9 SychO9 merged commit d400dcb into 2.x Jan 19, 2024
28 of 29 checks passed
@SychO9 SychO9 deleted the sm/dispatch-installation-package-build-workflow-onrelease branch January 19, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated workflow to generate installable flarum packages
4 participants