Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move gambits to frontend #3885

Merged

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Sep 17, 2023

Part of #3884

Changes proposed in this pull request:

  • Moves gambits to a frontend implementation where they are converted to filters.
  • This only works when using app.store.find to search resources.
  • There is still a lot of gambit concept code on the backend which will be dropped when following through other changes planned for the backend.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 added this to the 2.0 milestone Sep 17, 2023
@SychO9 SychO9 added the javascript Pull requests that update Javascript code label Sep 17, 2023
@SychO9 SychO9 marked this pull request as ready for review September 17, 2023 19:19
@SychO9 SychO9 requested a review from a team as a code owner September 17, 2023 19:19
@SychO9
Copy link
Member Author

SychO9 commented Sep 22, 2023

I'll merge any and all search-related PRs into a separate #3893 branch so that they can still be reviewed before merging this new branch into 2.x (I need to continue building on top of all the work done so far).

@SychO9 SychO9 merged commit 336ce00 into dev-search-drivers Sep 22, 2023
11 of 22 checks passed
@SychO9 SychO9 deleted the sm/support-search-drivers--gambits-frontend branch September 22, 2023 13:16
SychO9 added a commit that referenced this pull request Nov 11, 2023
* refactor: move gambits to frontend (#3885)
* refactor: move gambits to frontend
* test: GambitManager
* refactor: merge filterer and searcher concepts (#3892)
* chore: drop remaining backend regex gambits
* refactor: merge filterer & searcher concept
* refactor: adapt extenders
* refactor: no longer need to push gambits to `q`
* refactor: filters to gambits
* refactor: drop shred `Query` namespace
* chore: cleanup
* chore: leftover gambit references on the backend (#3894)
* chore: leftover gambit references on the backend
* chore: namespace
* feat: search driver backend extension API (#3902)
* feat: first iteration of search drivers
* feat: indexer API & tweaks
* feat: changes after POC driver
* fix: properly fire custom observables
* chore: remove debugging code
* fix: phpstan
* fix: custom eloquent events
* chore: drop POC usage
* test: indexer extender API
* fix: extension searcher fails without filters
* fix: phpstan
* fix: frontend created gambit
* feat: advanced page and localized driver settings (#3905)
* feat: allow getting total search results and replacing filters (#3906)
* feat: allow accessing total search results
* feat: allow replacing filters
* chore: phpstan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes javascript Pull requests that update Javascript code type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants