Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: advanced page and localized driver settings #3905

Merged
merged 5 commits into from
Oct 21, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Oct 21, 2023

Part of #3884 (#3884 (comment))

Changes proposed in this pull request:

  • Adds an advanced page where search drivers can be configured per model (will contain more settings in the future, hence the visual sections)
  • Localizes search driver names and model names (applies that to other driver settings like slug and display name drivers).
  • Adds a toggle underneath the clear cache button.
  • The toggle is hidden if the advanced page is empty (at this time that is the case when there are no alternative search drivers installed).

Screenshot
Screenshot from 2023-10-21 14-53-13
Screenshot from 2023-10-21 14-53-00

This is emulating having an alternative search driver installed for many models
Screenshot from 2023-10-21 14-52-43

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 added this to the 2.0 milestone Oct 21, 2023
@SychO9 SychO9 requested a review from a team as a code owner October 21, 2023 14:28
@SychO9 SychO9 added the javascript Pull requests that update Javascript code label Oct 21, 2023
@SychO9 SychO9 merged commit 3069498 into dev-search-drivers Oct 21, 2023
22 checks passed
@SychO9 SychO9 deleted the sm/dev-search-drivers--admin branch October 21, 2023 16:47
@SychO9
Copy link
Member Author

SychO9 commented Oct 21, 2023

I'll merge any and all search-related PRs into a separate #3893 branch so that they can still be reviewed before merging this new branch into 2.x (I need to continue building on top of all the work done so far).

SychO9 added a commit that referenced this pull request Nov 11, 2023
* refactor: move gambits to frontend (#3885)
* refactor: move gambits to frontend
* test: GambitManager
* refactor: merge filterer and searcher concepts (#3892)
* chore: drop remaining backend regex gambits
* refactor: merge filterer & searcher concept
* refactor: adapt extenders
* refactor: no longer need to push gambits to `q`
* refactor: filters to gambits
* refactor: drop shred `Query` namespace
* chore: cleanup
* chore: leftover gambit references on the backend (#3894)
* chore: leftover gambit references on the backend
* chore: namespace
* feat: search driver backend extension API (#3902)
* feat: first iteration of search drivers
* feat: indexer API & tweaks
* feat: changes after POC driver
* fix: properly fire custom observables
* chore: remove debugging code
* fix: phpstan
* fix: custom eloquent events
* chore: drop POC usage
* test: indexer extender API
* fix: extension searcher fails without filters
* fix: phpstan
* fix: frontend created gambit
* feat: advanced page and localized driver settings (#3905)
* feat: allow getting total search results and replacing filters (#3906)
* feat: allow accessing total search results
* feat: allow replacing filters
* chore: phpstan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/extensibility type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants