Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mentions,emoji): tie autocomplete to editor instance #3913

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Oct 29, 2023

Changes proposed in this pull request:
If an extension attempts to use multiple editors on the same page, you face issues with the autocomplete dropdowns since they assume there is only one editor on the page. By tying the autocomplete instance and element to the texteditor instance, this can be improved.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 added javascript Pull requests that update Javascript code type/extensibility labels Oct 29, 2023
@SychO9 SychO9 added this to the 2.0 milestone Oct 29, 2023
@SychO9 SychO9 requested a review from a team as a code owner October 29, 2023 10:41
@imorland imorland merged commit 208b94d into 2.x Nov 10, 2023
22 checks passed
@imorland imorland deleted the sm/texteditor-reusabilty branch November 10, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/extensibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants