Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: user pages history not registered #3916

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: user pages history not registered #3916

merged 1 commit into from
Nov 3, 2023

Conversation

imorland
Copy link
Member

@imorland imorland commented Nov 1, 2023

Submitting on behalf of @iPurpl3x

You know the back button in the header ? Well, all the pages extending the UserPage, don't get into the history and therefore when one comes from home (first page load), and the open the user page, there will be no back button. This fixes it.

@imorland imorland requested a review from a team as a code owner November 1, 2023 14:17
@imorland imorland added this to the 2.0 milestone Nov 1, 2023
@imorland imorland added javascript Pull requests that update Javascript code type/extensibility labels Nov 1, 2023
@SychO9 SychO9 changed the title fix: add history push fix: register user pages history Nov 3, 2023
@SychO9 SychO9 changed the title fix: register user pages history fix: user pages history not registered Nov 3, 2023
@SychO9 SychO9 merged commit e978e29 into 2.x Nov 3, 2023
22 checks passed
@SychO9 SychO9 deleted the im/userpage-history branch November 3, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code type/extensibility
Projects
None yet
Milestone
2.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@imorland @SychO9