Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: paginated list limit hard to change #3918

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Nov 3, 2023

Fixes #3861

Changes proposed in this pull request:

  • This PR creates a single source of truth for the limit (page size) of API lists.
  • The source of truth/limit value is always from the backend controller limit. That way, changing the limit there affects the rest, even frontend listings.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 requested a review from a team as a code owner November 3, 2023 08:55
@SychO9 SychO9 added javascript Pull requests that update Javascript code type/extensibility labels Nov 3, 2023
@SychO9 SychO9 self-assigned this Nov 3, 2023
@SychO9 SychO9 added this to the 2.0 milestone Nov 3, 2023
@imorland imorland merged commit 3107319 into 2.x Nov 10, 2023
22 checks passed
@imorland imorland deleted the sm/3861-single-source-of-truth-for-list-limit branch November 10, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/extensibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increasing the number of discussions shown per page
2 participants