Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: color input changes while typing #3919

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: color input changes while typing #3919

merged 1 commit into from
Nov 3, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Nov 3, 2023 •
edited
Loading

Fixes #3858

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 requested a review from a team as a code owner November 3, 2023 09:09
@SychO9 SychO9 added type/bug javascript Pull requests that update Javascript code labels Nov 3, 2023
@SychO9 SychO9 added this to the 2.0 milestone Nov 3, 2023
@davwheat
Copy link
Member

davwheat commented Nov 3, 2023

What's the issue with this updating live? Seems to match the behaviour of most colour pickers in other applications.

@SychO9
Copy link
Member Author

SychO9 commented Nov 3, 2023

@davwheat if I want to write #fff000 I wouldn't be able to since it would force complete as #ffffff

davwheat
davwheat approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@davwheat davwheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh.

@SychO9 SychO9 merged commit bee50be into 2.x Nov 3, 2023
22 checks passed
@SychO9 SychO9 deleted the sm/3858-color-input branch November 3, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code type/bug
Projects
None yet
Milestone
2.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Flarum ColorInput textbox issues
2 participants
@SychO9 @davwheat