fix: handled API errors break preloaded content #3920
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flarum/issue-archive#39
Changes proposed in this pull request:
Discussion
page or theIndexPage
run calls to the API using the internal API client. When that process errors out, it is handled by the API error handler which means we get a JSON response other than what we expect, leading to incomprehensible error pages where the frontend is broken, even when it is a simple 404 or 403 exception.Necessity
Confirmed
composer test
).