Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): convert empty links to buttons #3926

Merged
merged 3 commits into from
Sep 19, 2024
Merged

fix(a11y): convert empty links to buttons #3926

merged 3 commits into from
Sep 19, 2024

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Nov 10, 2023

Fixes #3519

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 requested a review from a team as a code owner November 10, 2023 10:46
@SychO9 SychO9 added the type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) label Nov 10, 2023
@SychO9 SychO9 added this to the 2.0 milestone Nov 10, 2023
@SychO9 SychO9 merged commit 2204157 into 2.x Sep 19, 2024
25 checks passed
@SychO9 SychO9 deleted the sm/3519-a11y-links-to-buttons branch September 19, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees
No one assigned
Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)
Projects
None yet
Milestone
2.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

[A11Y] Convert empty links to button elements
2 participants
@SychO9 @askvortsov1