Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] fix(Mentions): allow renderer to be used without context #3954

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented Jan 9, 2024

Related to #3953. See the description there for why this PR was opened. Also, please note that I have not actually tested it locally because I have not yet setup 2.x for development; therefore I don't know if the tests are actually passing.

I'll leave this PR as a Draft until I've confirmed this code actually works when I have 2.x setup or you may do it yourself.

@DavideIadeluca DavideIadeluca force-pushed the di/fix-post-mentions-formatter branch from c0c152c to 679a96f Compare January 10, 2024 10:08
@DavideIadeluca DavideIadeluca force-pushed the di/fix-post-mentions-formatter branch from 679a96f to 01283b3 Compare January 10, 2024 10:13
@imorland imorland added this to the 2.0 milestone Jan 10, 2024
@imorland imorland marked this pull request as ready for review January 10, 2024 11:04
@imorland imorland requested a review from a team as a code owner January 10, 2024 11:04
@imorland
Copy link
Member

Confirmed as working as intended on my local 2.x instance

@imorland imorland merged commit 430709b into flarum:2.x Jan 10, 2024
22 of 23 checks passed
@DavideIadeluca DavideIadeluca deleted the di/fix-post-mentions-formatter branch January 27, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants