-
-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for PgSQL #3985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
requested changes
Jun 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Should we show a warning in the extension UI and/or when enabling extensions if they don't specify compatibility with the current db driver?
extensions/statistics/src/Api/Controller/ShowStatisticsData.php
Outdated
Show resolved
Hide resolved
framework/core/migrations/2018_01_11_093900_change_access_tokens_columns.php
Outdated
Show resolved
Hide resolved
# Conflicts: # extensions/flags/src/Api/Controller/ListFlagsController.php # extensions/flags/tests/integration/api/flags/ListTest.php # extensions/flags/tests/integration/api/flags/ListWithTagsTest.php # extensions/likes/src/Api/LoadLikesRelationship.php # extensions/mentions/tests/integration/api/ListPostsTest.php # extensions/sticky/tests/integration/api/ListDiscussionsTest.php # framework/core/src/Foundation/ErrorServiceProvider.php # framework/core/tests/integration/api/access_tokens/CreateTest.php # framework/core/tests/integration/api/notifications/ListTest.php # framework/core/tests/integration/api/users/GroupSearchTest.php
askvortsov1
approved these changes
Jun 21, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the roadmap
Changes proposed in this pull request:
Postgres was trickier than SQLite, but that was mostly due to having some code that dates back years ago when eloquent/ the laravel schema builder was less flexible.
In most cases there should be no need to add any custum handling for the database driver when building queries. But that does become a necessity when writing more complex / larger queries. Example: fulltext search and statistics.
The easiest instance extension devs will run into when wanting to support PgSQL is the loose group by.
Screenshot
Necessity
Confirmed
composer test
).Required changes: