Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x add ability to prevent sending notifications with users that did not have email verified #3999

Closed
wants to merge 4 commits into from

Conversation

luceos
Copy link
Member

@luceos luceos commented Jun 16, 2024

This is a tentative PR to see if this is something we want.

reason

We are sending emails to user that never verified their email address. In addition we could use this property on the Users table to disable sending in the case that a) delivery fails (bounces) or b) users mark the mail as spam. In both these cases we no longer want to send email because that negatively affects our email sending reputation.

This is not just a global thing.

solution

Offer a blueprint method to signify whether the blueprint can ignore the verification of the user.

next

If we do this, I can update the blueprint implementations to match.

@luceos luceos requested a review from a team as a code owner June 16, 2024 11:55
@luceos luceos marked this pull request as draft June 16, 2024 15:04
@luceos luceos changed the title Email verification affects sending 2.x add ability to prevent sending notifications with users that did not have email verified Jun 16, 2024
@luceos luceos closed this Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants