chore: Bisect should use CacheClearCommand
in core instead
#4023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Flarum framework (https://github.com/flarum/framework/blob/2.x/framework/core/src/Extension/Bisect.php#L35) uses the
Composer\Command\ClearCacheCommand
class, but the corecomposer.json
does not require thecomposer/composer
package. This causes an error when running thephp flarum
command.To resolve this, there are two possible approaches:
composer/composer
package to the core and remove it from theextension-manager
.composer/composer
package.In this PR, I've opted for the first solution by moving the
composer/composer
package to the core composer.json and removing it from theextension-manager
.Fixes #0000
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot
QA
Necessity
Confirmed
composer test
).Required changes: