Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] [extensibility] feat: allow classes that extends AbstractJob to be placed on a specified queue #4026

Merged
merged 9 commits into from
Sep 29, 2024

Conversation

imorland
Copy link
Member

Changes proposed in this pull request:
Add a static property to AbstractJob, so that any class extending it may specify which queue it should be dispatched on.

Reviewers should focus on:
All jobs within core and extensions have had their constructor updated to also call parent::__construct(). My understanding that if a 3rd party does not call the parent constructor, it simply means that the $onQueue won't be set, therefore not breaking any compatibility?

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: TBC

@imorland imorland requested a review from a team as a code owner September 26, 2024 17:55
@imorland imorland added this to the 1.8.6 milestone Sep 26, 2024
@imorland imorland changed the title [1.x] [extensibility] feat: allow classes that extends AbstractJob to be placed on a specified queue [1.x] [extensibility] feat: allow classes that extends AbstractJob to be placed on a specified queue Sep 26, 2024
@imorland imorland merged commit 2c4d64c into 1.x Sep 29, 2024
314 checks passed
@imorland imorland deleted the im/queue branch September 29, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants