Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] [extensibility] feat: allow modifying the discussion title on PostsUserPage #4031

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

imorland
Copy link
Member

Changes proposed in this pull request:
As title says, extract the discussion title from the view and place it into a function, so that it can be updated from 3rd party extensions

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@imorland imorland added javascript Pull requests that update Javascript code type/extensibility labels Sep 28, 2024
@imorland imorland added this to the 1.8.6 milestone Sep 28, 2024
@imorland imorland requested a review from a team as a code owner September 28, 2024 06:22
@imorland imorland merged commit 7540ede into 1.x Sep 28, 2024
313 of 314 checks passed
@imorland imorland deleted the im/post-user-page branch September 28, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/extensibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant