Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: wrap RepositoryModal's fields in Form component #4034

Merged
merged 2 commits into from
Sep 28, 2024
Merged

chore: wrap RepositoryModal's fields in Form component #4034

merged 2 commits into from
Sep 28, 2024

Conversation

datlechin
Copy link
Contributor

Before:
Screenshot 2024-09-28 at 22 49 40

After:
Screenshot 2024-09-28 at 22 49 54

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@datlechin datlechin requested a review from a team as a code owner September 28, 2024 15:50
@SychO9 SychO9 merged commit f8560ef into flarum:2.x Sep 28, 2024
18 checks passed
@datlechin datlechin deleted the chore/wrap-repository-modal-in-form branch September 28, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@datlechin @SychO9