-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update FontAwesome v6 icon search link #4036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please do the same for any other fonteawesome links? like the ones in tags for example, there might be others.
I would suggest creating a new property in the common/Application class, maybe named refs
.
and then we could use that (app.refs.fontawesome
) every time we need to link to fontawesome search.
Also please use https://fontawesome.com/v6/icons?o=r&m=free
@SychO9, I have added a new property in the common Application, following your suggestion, to reuse |
Co-authored-by: Sami Mazouz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #0000
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot
QA
Necessity
Confirmed
composer test
).Required changes: