Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update FontAwesome v6 icon search link #4036

Merged
merged 5 commits into from
Sep 29, 2024

Conversation

datlechin
Copy link
Contributor

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@datlechin datlechin requested a review from a team as a code owner September 28, 2024 16:16
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please do the same for any other fonteawesome links? like the ones in tags for example, there might be others.

I would suggest creating a new property in the common/Application class, maybe named refs.

and then we could use that (app.refs.fontawesome) every time we need to link to fontawesome search.

Also please use https://fontawesome.com/v6/icons?o=r&m=free

@datlechin
Copy link
Contributor Author

@SychO9, I have added a new property in the common Application, following your suggestion, to reuse app.refs.fontawesome. Please let me know if any changes are needed

@datlechin datlechin requested a review from SychO9 September 28, 2024 17:04
@datlechin datlechin requested a review from SychO9 September 28, 2024 17:58
Co-authored-by: Sami Mazouz <[email protected]>
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SychO9 SychO9 added this to the 2.0 milestone Sep 29, 2024
@SychO9 SychO9 merged commit 1a12209 into flarum:2.x Sep 29, 2024
18 checks passed
@datlechin datlechin deleted the chore/fontawesome-v6-ref branch September 29, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants