Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] fix(core): revert extensibility improvement for replyCountItem() #4051

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

DavideIadeluca
Copy link
Contributor

Fixes #0000

Changes proposed in this pull request:
This fixes a breaking change in #4048 with third-party extensions calling replyCountItem() and not expecting it to be an array.

Reviewers should focus on:

Screenshot
No differences

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

This fixes a breaking change with third-party extensions calling `replyCountItem()` and not expecting it to be an array.
@DavideIadeluca DavideIadeluca marked this pull request as ready for review September 30, 2024 14:29
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner September 30, 2024 14:29
@DavideIadeluca DavideIadeluca changed the title fix(core): revert extensibility improvements for replyCountItem() [1.x] fix(core): revert extensibility improvement for replyCountItem() Sep 30, 2024
@imorland imorland added this to the 1.8.6 milestone Sep 30, 2024
@imorland imorland merged commit 1fee96a into flarum:1.x Sep 30, 2024
274 checks passed
@imorland imorland deleted the di/fix-breaking-change branch September 30, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants