Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] feat: allow to customize time formats through translations #4053

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

rob006
Copy link
Contributor

@rob006 rob006 commented Oct 1, 2024

Alternative PR for #4029, which implements concept from #4029 (comment).

It introduces 3 new keys to translate - now date formats can be adjusted by language pack or forum owner (for example through Linguist extension).

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@rob006 rob006 requested a review from a team as a code owner October 1, 2024 20:03
@rob006 rob006 mentioned this pull request Oct 1, 2024
10 tasks
@rob006 rob006 changed the title Allow to customize time formats feat: allow to customize time formats through translations Oct 1, 2024
@rob006 rob006 changed the title feat: allow to customize time formats through translations [1.x] feat: allow to customize time formats through translations Oct 1, 2024
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, however I'll admit that I'm not overly familiar with different date formats, etc.

If this were included, I'd like to see an update to the Flarum documentation documenting how developers can use these changes in their customizations..

For sanity sake, let's ask @SychO9 to also take a look at this

@imorland imorland requested a review from SychO9 October 2, 2024 06:56
@imorland imorland added javascript Pull requests that update Javascript code type/extensibility labels Oct 2, 2024
@imorland imorland added this to the 1.8.6 milestone Oct 2, 2024
@imorland imorland merged commit d5a1653 into flarum:1.x Oct 3, 2024
274 checks passed
@rob006 rob006 deleted the human-time branch October 3, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/extensibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants