Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(flags): require flarum/core ^1.8.6 #4061

Merged
merged 1 commit into from
Oct 8, 2024
Merged

chore(flags): require flarum/core ^1.8.6 #4061

merged 1 commit into from
Oct 8, 2024

Conversation

DavideIadeluca
Copy link
Contributor

Fixes #0000

Changes proposed in this pull request:
Require flarum/core ^1.8.6 due to changes in #4047

Reviewers should focus on:

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca requested a review from a team as a code owner October 8, 2024 06:31
@imorland imorland added this to the 1.8.6 milestone Oct 8, 2024
@imorland
Copy link
Member

imorland commented Oct 8, 2024

flags tests expected to fail until 1.8.6 is tagged

@imorland imorland merged commit 9295e7b into flarum:1.x Oct 8, 2024
274 checks passed
@imorland imorland deleted the di/composer-constraint branch October 8, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.6
Development

Successfully merging this pull request may close these issues.
2 participants
@DavideIadeluca @imorland