Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] [suspend] fix: previously suspended admin users cannot remove their avatar after suspension #4071

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

imorland
Copy link
Member

@imorland imorland commented Oct 14, 2024

https://discuss.flarum.org/d/32901-staff-diary-v20-cycle/246

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@imorland imorland requested a review from a team as a code owner October 14, 2024 14:54
@imorland imorland changed the title [1.x] [suspend] fix: formally suspended admin users cannot remove their avatar after suspension [1.x] [suspend] fix: previously suspended admin users cannot remove their avatar after suspension Oct 14, 2024
@imorland imorland merged commit 3a45ebc into 1.x Oct 15, 2024
314 checks passed
@imorland imorland deleted the im/suspend branch October 15, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants