Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Alert component layout #4087

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

YUCLing
Copy link
Contributor

@YUCLing YUCLing commented Oct 22, 2024

Fixes #0000

Changes proposed in this pull request:
Adds gap for .Alert-container in admin styles.

This change improves the readability of the alert.

Reviewers should focus on:

Screenshot
Before
image
After
image

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@YUCLing YUCLing requested a review from a team as a code owner October 22, 2024 10:57
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This is what it actually should look like:
image

looks like I broke by adding flex display on the alert container while trying to fix this:
image

Best way to fix this is to wrap Alert-title and Alert-body divs into a Alert-content div.

@YUCLing YUCLing changed the title Add gap for admin alert container Fix Alert component layout Oct 22, 2024
@YUCLing
Copy link
Contributor Author

YUCLing commented Oct 22, 2024

Best way to fix this is to wrap Alert-title and Alert-body divs into a Alert-content div.

Fixed it. See if it looks good to you.
image
image

@YUCLing YUCLing requested a review from SychO9 October 22, 2024 15:19
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SychO9 SychO9 merged commit dc5a7ac into flarum:2.x Oct 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants