New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent wiping out existing database on install #4092

Merged

SychO9 merged 1 commit into 2.x from sm/4018

Oct 25, 2024

Member

SychO9 commented Oct 24, 2024 •

edited

Loading

Fixes #4018

Changes proposed in this pull request:

Checks for the existence of the migrations table (this is how we checked before we added the install.sql dumps).

Necessity

Has the problem that is being solved here been clearly explained?
If applicable, have various options for solving this problem been considered?
For core PRs, does this need to be in core, or could it be in an extension?
Are we willing to maintain this for years / potentially forever?

Confirmed

Frontend changes: tested on a local Flarum installation.
Backend changes: tests are green (run composer test).
Core developer confirmed locally this works as intended.
Tests have been added, or are not appropriate here.

Required changes:

Related documentation PR: (Remove if irrelevant)


          fix: prevent wiping out existing database on install

7b56d2b

SychO9 requested a review from a team as a code owner

October 24, 2024 18:18

SychO9 merged commit bb29e87 into 2.x

25 checks passed

SychO9 deleted the sm/4018 branch

October 25, 2024 19:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet