Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove frontend scoping in Modal #4101

Closed
wants to merge 1 commit into from
Closed

chore: remove frontend scoping in Modal #4101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions framework/core/js/src/common/components/Modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,15 @@ export default abstract class Modal<ModalAttrs extends IInternalModalAttrs = IIn
*
* If `false`, no close button is shown.
*/
protected static readonly isDismissibleViaCloseButton: boolean = true;
static isDismissibleViaCloseButton: boolean = true;
/**
* Can the modal be dismissed by pressing the Esc key on a keyboard?
*/
protected static readonly isDismissibleViaEscKey: boolean = true;
static isDismissibleViaEscKey: boolean = true;
/**
* Can the modal be dismissed via a click on the backdrop.
*/
protected static readonly isDismissibleViaBackdropClick: boolean = true;
static isDismissibleViaBackdropClick: boolean = true;

static get dismissibleOptions(): IDismissibleOptions {
return {
Expand All @@ -52,7 +52,7 @@ export default abstract class Modal<ModalAttrs extends IInternalModalAttrs = IIn
};
}

protected loading: boolean = false;
loading: boolean = false;

/**
* Attributes for an alert component to show below the header.
Expand Down Expand Up @@ -103,11 +103,11 @@ export default abstract class Modal<ModalAttrs extends IInternalModalAttrs = IIn
);
}

protected wrapper(children: Mithril.Children): Mithril.Children {
wrapper(children: Mithril.Children): Mithril.Children {
return <>{children}</>;
}

protected inner(): Mithril.Children {
inner(): Mithril.Children {
return (
<>
<div className="Modal-header">
Expand Down Expand Up @@ -162,7 +162,7 @@ export default abstract class Modal<ModalAttrs extends IInternalModalAttrs = IIn
m.redraw();
}

protected get dismissibleOptions(): IDismissibleOptions {
get dismissibleOptions(): IDismissibleOptions {
return (this.constructor as typeof Modal).dismissibleOptions;
}
}
Loading