Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot cast as json on mariadb 10 #4110

Merged
merged 4 commits into from
Nov 15, 2024
Merged

fix: cannot cast as json on mariadb 10 #4110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99e3050
fix: cannot cast as json on mariadb 10
luceos Nov 13, 2024
f7e6e56
Apply fixes from StyleCI
StyleCIBot Nov 13, 2024
3b45d1e
chore: cleanup and fix sqlite ci error
luceos Nov 13, 2024
4ce58e0
Apply fixes from StyleCI
StyleCIBot Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 25 additions & 14 deletions framework/core/migrations/2024_05_05_000001_convert_preferences_to_json_in_users.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,24 +7,32 @@
* LICENSE file that was distributed with this source code.
*/

use Illuminate\Database\MariaDbConnection;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Schema\Builder;

return [
'up' => function (Builder $schema) {
$preferences = $schema->getConnection()->getSchemaGrammar()->wrap('preferences');
$connection = $schema->getConnection();
$driver = $connection->getDriverName();

if ($schema->getConnection()->getDriverName() === 'pgsql') {
$users = $schema->getConnection()->getSchemaGrammar()->wrapTable('users');
$schema->getConnection()->statement("ALTER TABLE $users ALTER COLUMN $preferences TYPE JSON USING $preferences::TEXT::JSON");
$preferences = $connection->getSchemaGrammar()->wrap('preferences');

if ($driver === 'pgsql') {
$users = $connection->getSchemaGrammar()->wrapTable('users');
$connection->statement("ALTER TABLE $users ALTER COLUMN $preferences TYPE JSON USING $preferences::TEXT::JSON");
} else {
$schema->table('users', function (Blueprint $table) {
$table->json('preferences_json')->nullable();
});

if ($schema->getConnection()->getDriverName() === 'mysql') {
$schema->getConnection()->table('users')->update([
'preferences_json' => $schema->getConnection()->raw("CAST(CONVERT($preferences USING utf8mb4) AS JSON)"),
if ($connection instanceof MariaDbConnection) {
$connection->table('users')->update([
'preferences_json' => $connection->raw("IF(JSON_VALID(CONVERT($preferences USING utf8mb4)), CONVERT($preferences USING utf8mb4), NULL)"),
]);
} elseif ($driver === 'mysql') {
$connection->table('users')->update([
'preferences_json' => $connection->raw("CAST(CONVERT($preferences USING utf8mb4) AS JSON)"),
]);
}

Expand All @@ -39,19 +47,22 @@
},

'down' => function (Builder $schema) {
$preferences = $schema->getConnection()->getSchemaGrammar()->wrap('preferences');
$connection = $schema->getConnection();
$driver = $connection->getDriverName();

$preferences = $connection->getSchemaGrammar()->wrap('preferences');

if ($schema->getConnection()->getDriverName() === 'pgsql') {
$users = $schema->getConnection()->getSchemaGrammar()->wrapTable('users');
$schema->getConnection()->statement("ALTER TABLE $users ALTER COLUMN $preferences TYPE BYTEA USING preferences::TEXT::BYTEA");
if ($driver === 'pgsql') {
$users = $connection->getSchemaGrammar()->wrapTable('users');
$connection->statement("ALTER TABLE $users ALTER COLUMN $preferences TYPE BYTEA USING preferences::TEXT::BYTEA");
} else {
$schema->table('users', function (Blueprint $table) {
$table->binary('preferences_binary')->nullable();
});

if ($schema->getConnection()->getDriverName() === 'mysql') {
$schema->getConnection()->table('users')->update([
'preferences_binary' => $schema->getConnection()->raw($preferences),
if ($driver === 'mysql') {
$connection->table('users')->update([
'preferences_binary' => $connection->raw($preferences),
]);
}

Expand Down
39 changes: 25 additions & 14 deletions framework/core/migrations/2024_05_07_000001_convert_data_to_json_in_notifications.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,31 @@
* LICENSE file that was distributed with this source code.
*/

use Illuminate\Database\MariaDbConnection;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Schema\Builder;

return [
'up' => function (Builder $schema) {
if ($schema->getConnection()->getDriverName() === 'pgsql') {
$notifications = $schema->getConnection()->getSchemaGrammar()->wrapTable('notifications');
$data = $schema->getConnection()->getSchemaGrammar()->wrap('data');
$schema->getConnection()->statement("ALTER TABLE $notifications ALTER COLUMN $data TYPE JSON USING data::TEXT::JSON");
$connection = $schema->getConnection();
$driver = $connection->getDriverName();

if ($driver === 'pgsql') {
$notifications = $connection->getSchemaGrammar()->wrapTable('notifications');
$data = $connection->getSchemaGrammar()->wrap('data');
$connection->statement("ALTER TABLE $notifications ALTER COLUMN $data TYPE JSON USING data::TEXT::JSON");
} else {
$schema->table('notifications', function (Blueprint $table) {
$table->json('data_json')->nullable();
});

if ($schema->getConnection()->getDriverName() === 'mysql') {
$schema->getConnection()->table('notifications')->update([
'data_json' => $schema->getConnection()->raw('CAST(CONVERT(data USING utf8mb4) AS JSON)'),
if ($connection instanceof MariaDbConnection) {
$connection->table('notifications')->update([
'data_json' => $connection->raw('IF(JSON_VALID(CONVERT(data USING utf8mb4)), CONVERT(data USING utf8mb4), NULL)'),
]);
} elseif ($driver === 'mysql') {
$connection->table('notifications')->update([
'data_json' => $connection->raw('CAST(CONVERT(data USING utf8mb4) AS JSON)'),
]);
}

Expand All @@ -38,18 +46,21 @@
},

'down' => function (Builder $schema) {
if ($schema->getConnection()->getDriverName() === 'pgsql') {
$notifications = $schema->getConnection()->getSchemaGrammar()->wrapTable('notifications');
$data = $schema->getConnection()->getSchemaGrammar()->wrap('data');
$schema->getConnection()->statement("ALTER TABLE $notifications ALTER COLUMN $data TYPE BYTEA USING data::TEXT::BYTEA");
$connection = $schema->getConnection();
$driver = $connection->getDriverName();

if ($driver === 'pgsql') {
$notifications = $connection->getSchemaGrammar()->wrapTable('notifications');
$data = $connection->getSchemaGrammar()->wrap('data');
$connection->statement("ALTER TABLE $notifications ALTER COLUMN $data TYPE BYTEA USING data::TEXT::BYTEA");
} else {
$schema->table('notifications', function (Blueprint $table) {
$table->binary('data_binary')->nullable();
});

if ($schema->getConnection()->getDriverName() === 'mysql') {
$schema->getConnection()->table('notifications')->update([
'data_binary' => $schema->getConnection()->raw('data'),
if ($driver === 'mysql') {
$connection->table('notifications')->update([
'data_binary' => $connection->raw('data'),
]);
}

Expand Down
Loading