feat: allow adding endpoints before/after others #4115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #4106
Adds:
endpointsBefore('name', fn () => [ ... ])
endpointsAfter('name', fn () => [ ... ])
endpointsBeforeAll(fn () => [ ... ])
It is currently impossible to add certain endpoints without breaking existing ones. For example, if you have the following endpoints:
DELETE /api/discussions/{id}
You would not be able to add custom endpoints with the following paths:
DELETE /api/discussions/all
because the pattern which catches the
ID
for the existing endpoint would also catchall
. But if the custom endpoint was added before the existing, the problem would be solved.Of course another way to solve this would be to enforce that the
id
parameter is an integer:DELETE /api/discussions/{id:\d+}
but while that might be applicable for this example, other routes such as the
GET
one allow using slugs.