Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tags] Wrong tag input width if contains CJK characters #4127

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

YUCLing
Copy link
Contributor

@YUCLing YUCLing commented Nov 23, 2024

Fixes same issue mentioned in #4094

Changes proposed in this pull request:
Same as #4094, but in a much better and lighter approach.

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@YUCLing YUCLing requested a review from a team as a code owner November 23, 2024 03:40
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SychO9 SychO9 added this to the 2.0 milestone Nov 29, 2024
@SychO9 SychO9 merged commit 33a72f5 into flarum:2.x Nov 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants