Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate mariadb driver #4132

Merged
merged 5 commits into from
Dec 2, 2024
Merged

feat: separate mariadb driver #4132

merged 5 commits into from
Dec 2, 2024

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Nov 29, 2024

Fixes #0000

Changes proposed in this pull request:

  • Fixes checking of MariaDB in the migrations to using ->isMaria()
  • Adds mariadb as a separate database driver, laravel 11 has done the same in order to more easily handle the growing differences between mysql and mariadb.
  • This will not break things for instances using mariadb under the mysql driver. But we need to document switching to mariadb driver nonetheless.

Screenshot
image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@SychO9 SychO9 self-assigned this Nov 30, 2024
@SychO9 SychO9 added this to the 2.0 milestone Nov 30, 2024
@SychO9 SychO9 marked this pull request as ready for review November 30, 2024 13:05
@SychO9 SychO9 requested a review from a team as a code owner November 30, 2024 13:05
@luceos
Copy link
Member

luceos commented Dec 1, 2024

@SychO9 feel free to merge. I will do a test run early this week on Nightly (if it doesn't already auto fix with this).

@luceos luceos merged commit 097a542 into 2.x Dec 2, 2024
28 checks passed
@luceos luceos deleted the sm/mariadb-driver branch December 2, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants