Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve the flarum validator #4133

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Dec 6, 2024

Fixes flarum/issue-archive#178
Fixes #3612

Changes proposed in this pull request:
Improves the validator by fixing two issues:

  • The ability to validate missing keys.
  • Path based rules not picked up.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 added the type/bug label Dec 6, 2024
@SychO9 SychO9 added this to the 2.0.0-beta.1 milestone Dec 6, 2024
@SychO9 SychO9 self-assigned this Dec 6, 2024
@SychO9 SychO9 requested a review from a team as a code owner December 6, 2024 09:05
@SychO9 SychO9 merged commit 570580d into 2.x Dec 6, 2024
28 checks passed
@SychO9 SychO9 deleted the sm/allow-validating-missing-keys branch December 6, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants