Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BidTraceV3 #260

Closed
wants to merge 1 commit into from
Closed

BidTraceV3 #260

wants to merge 1 commit into from

Conversation

metachris
Copy link
Collaborator

📝 Summary

Update BidTrace to V3:

To do:

  • Add extra_data
  • Test in testnets

✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

Codecov Report

Merging #260 (c90d91a) into main (174a4a6) will increase coverage by 0.13%.
The diff coverage is 1.81%.

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   23.05%   23.18%   +0.13%     
==========================================
  Files          19       19              
  Lines        2594     2579      -15     
==========================================
  Hits          598      598              
+ Misses       1917     1902      -15     
  Partials       79       79              
Flag Coverage Δ
unittests 23.18% <1.81%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
common/types.go 0.00% <0.00%> (ø)
database/database.go 13.81% <0.00%> (ø)
database/mockdb.go 0.00% <0.00%> (ø)
database/typesconv.go 0.00% <0.00%> (ø)
datastore/redis.go 57.89% <0.00%> (ø)
services/api/service.go 15.73% <14.28%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants