use HMSET for batch Builder status store

[EliasiOfir]

📝 Summary

Moving Builders status Redis initial sync from DB to use batch requests (HMSET) and not a request per builder (HSET).
Also added tests to cover this change.

⛱ Motivation and Context

following issue #204, this is one small step forward to using batch requests

---

✅ I have run these commands

• make lint
• make test-race
• go mod tidy
• I have seen and agree to CONTRIBUTING.md

[metachris]

That's great, thanks! Could you also apply that for writing known validators to Redis? These are 500k requests and takes a loooong time:

mev-boost-relay/services/housekeeper/housekeeper.go

Lines 207 to 235 in cfe9c9c

	log.Debug("Writing to Redis...")
	timeStartWriting := time.Now()
	// This process can take very long, that's why it prints a log line every 10k validators
	printCounter := len(hk.proposersAlreadySaved) == 0 // only do this on service startup
	i := 0
	newValidators := 0
	for _, validator := range validators {
	i++
	if printCounter && i%10000 == 0 {
	log.Debugf("writing to redis: %d / %d", i, numValidators)
	}
	// avoid resaving if index->pubkey mapping is the same
	prevPubkeyForIndex := hk.proposersAlreadySaved[validator.Index]
	if prevPubkeyForIndex == validator.Validator.Pubkey {
	continue
	}
	err := hk.redis.SetKnownValidator(types.PubkeyHex(validator.Validator.Pubkey), validator.Index)
	if err != nil {
	log.WithError(err).WithField("pubkey", validator.Validator.Pubkey).Error("failed to set known validator in Redis")
	} else {
	hk.proposersAlreadySaved[validator.Index] = validator.Validator.Pubkey
	newValidators++
	}
	}

[codecov-commenter]

Codecov Report

Merging #373 (eb54c50) into main (28168e1) will increase coverage by 0.29%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
+ Coverage   19.92%   20.21%   +0.29%     
==========================================
  Files          21       21              
  Lines        4056     4062       +6     
==========================================
+ Hits          808      821      +13     
+ Misses       3145     3137       -8     
- Partials      103      104       +1     

Flag	Coverage Δ
unittests	20.21% <100.00%> (+0.29%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
datastore/redis.go	64.75% <100.00%> (+2.79%)	⬆️

[EliasiOfir]

That's great, thanks! Could you also apply that for writing known validators to Redis? These are 500k requests and takes a loooong time:

mev-boost-relay/services/housekeeper/housekeeper.go

Lines 207 to 235 in cfe9c9c

	log.Debug("Writing to Redis...")
	timeStartWriting := time.Now()
	// This process can take very long, that's why it prints a log line every 10k validators
	printCounter := len(hk.proposersAlreadySaved) == 0 // only do this on service startup
	i := 0
	newValidators := 0
	for _, validator := range validators {
	i++
	if printCounter && i%10000 == 0 {
	log.Debugf("writing to redis: %d / %d", i, numValidators)
	}
	// avoid resaving if index->pubkey mapping is the same
	prevPubkeyForIndex := hk.proposersAlreadySaved[validator.Index]
	if prevPubkeyForIndex == validator.Validator.Pubkey {
	continue
	}
	err := hk.redis.SetKnownValidator(types.PubkeyHex(validator.Validator.Pubkey), validator.Index)
	if err != nil {
	log.WithError(err).WithField("pubkey", validator.Validator.Pubkey).Error("failed to set known validator in Redis")
	} else {
	hk.proposersAlreadySaved[validator.Index] = validator.Validator.Pubkey
	newValidators++
	}
	}

probably also need to paginate that 500,000...

[metachris]

Asking for a bit of patience, as we're working on other important PRs to get merged first (in particular #380)