Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change specific error log to info because it's expected nowadays #574

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

metachris
Copy link
Collaborator

📝 Summary

This error is logges often, because it will happen if mev-boost does a getPayload request for a bid from other relays.


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@metachris metachris changed the base branch from main to deneb January 25, 2024 18:53
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (930f084) 33.24% compared to head (8cfb8ae) 33.24%.
Report is 30 commits behind head on deneb.

Files Patch % Lines
services/api/service.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            deneb     #574   +/-   ##
=======================================
  Coverage   33.24%   33.24%           
=======================================
  Files          24       24           
  Lines        5087     5087           
=======================================
  Hits         1691     1691           
  Misses       3177     3177           
  Partials      219      219           
Flag Coverage Δ
unittests 33.24% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metachris metachris merged commit 1ffdc1a into deneb Jan 25, 2024
2 checks passed
@metachris metachris deleted the fix-info-msg branch January 25, 2024 18:58
blombern pushed a commit to ultrasoundmoney/mev-boost-relay that referenced this pull request Jan 30, 2024
blombern pushed a commit to ultrasoundmoney/mev-boost-relay that referenced this pull request Jan 30, 2024
avalonche added a commit that referenced this pull request Jan 30, 2024
* Remove bellatrix from wrapper types (#475)

* Remove bellatrix from wrapper types

* remove test logs

* Remove get header wrapper types (#477)

* Remove signed blinded beacon block wrapper (#482)

* remove signed blinded beacon block wrapper type

* linting

* remove signed beacon block wrapper types (#483)

* Remove submit block request wrapper (#485)

* remove submit block request wrapper types

* fix tests

* fix lint

* Upgrade go-boost-utils (#488)

* Upgrade go-boost-utils

* pr comments

* remove commented out code

* Add custom json marshalling for versioned structs (#493)

* Add deneb signature checking for block contents

* Add deneb support for type conversions

* Add redis and database tests to store deneb payloads

* Block submission to v3 validation endpoint

* Update signed block conversions

* Replace some expectCont with expectOk (#509)

* Allow fork epochs to be 0

* Make attestantio import names consistent (#510)

* Make attestantio import names consistent

* Fix linter errors & two comments

* Fix mistake in redis prefix name (#517)

* Fix mistake in redis prefix for deneb

* Fix typo in prefix

* rebase conflicts from main

* update submit block request

* bug fixes

* fix blob sidecar signature

* ssz encode request to publish block

* use v2 publish endpoint by default

* go mod tidy

* update relay to latest builder-specs

* update go mod

* fix lint and tests

* switch to json encoding instead of ssz for block publishing v2

* add blob logging

* address pr comments

* Handle no deneb fork schedule from beacon client (#572)

* backwards compatibility if no deneb schedule

* Update services/api/service.go

Co-authored-by: Chris Hager <[email protected]>

---------

Co-authored-by: Chris Hager <[email protected]>

* change specific error log to info because it's expected nowadays (#574)

* Add json and ssz marshalling tests (#573)

* add test vectors

* linting

---------

Co-authored-by: Justin Traglia <[email protected]>
Co-authored-by: Chris Hager <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants