-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redacted
and full
telemetry servers
#164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebf5626
to
a212aa2
Compare
Benchmark results for
|
Date (UTC) | 2024-09-10T17:58:25+00:00 |
Commit | 46c3067084f337085df042b5ef87b4ab1d52c429 |
Base SHA | ccf4677ba3aa8cc1b50e14b6bda4947322ee48a2 |
Significant changes
Benchmark | Mean | Status |
---|---|---|
MEV-Boost SubmitBlock serialization/JSON encoding | 64.95% | Performance has degraded. |
metachris
reviewed
Sep 3, 2024
We already have server that you can hook on that serves telemetry + other debug endpoints we can add health endpoint there too. What is the justification for not using it and for adding additional server instead? |
dvush
reviewed
Sep 3, 2024
dvush
requested changes
Sep 3, 2024
a014271
to
0d6cc40
Compare
opaque
and debug
servers
opaque
and debug
serversopaque
and debug
servers
opaque
and debug
serversopaque
and debug
telemetry servers
0d6cc40
to
24b9268
Compare
The names opaque_server/debug_server tells me nothing. I liked more "telemetry". |
ZanCorDX
approved these changes
Sep 9, 2024
opaque
and debug
telemetry serversrestricted
and full
telemetry servers
eee2416
to
446d8ef
Compare
446d8ef
to
8f5368f
Compare
dvush
approved these changes
Sep 10, 2024
restricted
and full
telemetry serversredacted
and full
telemetry servers
b6b3407
to
46c3067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new moduleserver
insidelive_builder
Server exposes a single fnstart
, which starts an actix server on the given portInitial server implementation just exposes one route/health
that responds 200Adds new base config itemlive_builder_server_port
Server is spawned when running thelive_builder
cliBackground
Solution
full
andredacted
.full
: what we have now, exposes all operational data without regard for whether it is sensitiveredacted
: new server that initially only exposes a healthcheck endpoint (can be extended later). This server is safe to always be exposed by tdx builders.