fix(reth-builder): Remove duplicate engine extra arguments. #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanschneider
requested review from
dvush,
ZanCorDX and
ferranbt
as code owners
ferranbt
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This issue with #429 was found during devnet-6 testing. Cherry picking this from #434.
💡 Motivation and Context
This fixes
reth-rbuilderwhich is used by EF DevOps for devnets and kurtosis.Longer term, we probably want to juse force reth to use the required values of
0forengine.persistence-thresholdandengine.memory-block-buffer-target.✅ I have completed the following steps:
make lintmake test