Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing slot regression, better track of payload attributes in logs #459

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

dvush
Copy link
Contributor

@dvush dvush commented Mar 4, 2025

  • It introduces unique payload_id for each payload received from the CL
  • Multiple logs are added to track possible reasons for not building with the given payload_id

It was found that in current develop we miss approx. 5% of the slots because we don't cancel old jobs mid slot anymore when reth goes to the next block.

This adds a new job for each slot run_check_if_parent_block_is_last_block that explicitly checks last reth block every 100ms and cancels payload if we can't use it anymore. This fixes the issue above and makes us more robust since before we relied on reth giving us specific error type to cancel slot when reth updated last block and now we check it explicitly.


✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@dvush dvush requested review from ZanCorDX and ferranbt as code owners March 4, 2025 12:56
Copy link
Contributor

@ZanCorDX ZanCorDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can payload_id be incremental instead of rand::random()?

@dvush dvush merged commit 14ad90a into develop Mar 5, 2025
4 checks passed
@dvush dvush deleted the track_missing_slots branch March 5, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants