Update Lyrics to 0.9.0 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also: - Replaces Elementary's base app by the "org.freedesktop.Sdk.Extension.vala" extension. That's needed because even the 23.08 branch of the base app ships an old version of valac, which is unable to build the app. - Updates the runtime to version 24.08. - Replaces overly broad "--socket=session-bus" permission by "--talk-name=org.mpris.MediaPlayer2.*". - Makes Wayland the default. - Includes 6 patches required to pass Flathub's validations, deal with some app bugs, and drop unused dependencies. These patches will be upstreamed later. - Includes "libgee" as a direct app dependency. This was not required before because it was included in Elementary's base app. - Drops "eos-theme.patch", which does not apply cleanly against this version of Lyrics. - Drops the "libxmlbird" dependency, which is not required as of this version of Lyrics. - Removes the "python3-doit.json" file, which was only required to build "libxmlbird". - Add "x-checker-data" information to both Lyrics and "libgee", which will hopefully help maintainers in keeping them to date. This also introduces two other "modules" required to build the app: - pypi-dependencies.json: Direct app dependencies, generated with the following flatpak-pip-generator [1] command, using upstream's "requirements.txt" file: $ flatpak-pip-generator --runtime org.freedesktop.Sdk//24.08 --requirements-file requirements.txt --output pypi-dependencies - python3-skbuild.json: Build dependencies of "rapidfuzz", a direct dependency of the app. It was generated with the following command: $ flatpak-pip-generator --runtime org.freedesktop.Sdk//24.08 scikit-build==0.18.1 --output python3-skbuild [1] https://github.com/flatpak/flatpak-builder-tools/tree/master/pip
|
Started test build 155432 |
|
Build 155432 successful |
|
This is how the app looks on Plasma 6.2 (X11):
It'd be great if someone else could test this on Wayland, and optionally on a different desktop environment as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also:
org.freedesktop.Sdk.Extension.valaextension. That's needed because even the23.08branch of the base app ships an old version ofvalac, which is unable to build the app.24.08.--socket=session-buspermission by--talk-name=org.mpris.MediaPlayer2.*.libgeeas a direct app dependency. This was not required before because it was included in Elementary's base app.eos-theme.patch, which does not apply cleanly against this version of Lyrics.libxmlbirddependency, which is not required as of this version of Lyrics.python3-doit.jsonfile, which was only required to buildlibxmlbird.x-checker-datainformation to Lyrics andlibgee, which will hopefully help maintainers in keeping them up to date.This also introduces two other "modules" required to build the app:
pypi-dependencies.json: Direct app dependencies, generated with the followingflatpak-pip-generatorcommand, using upstream'srequirements.txtfile:python3-skbuild.json: Build dependencies ofrapidfuzz, a direct dependency of the app. It was generated with the following command:Closes #2
Closes #3
Closes #4
Closes #6