Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refs #PMP2-378 GI on EXP.PART #108

Merged
merged 9 commits into from
Feb 24, 2025
Merged

refs #PMP2-378 GI on EXP.PART #108

merged 9 commits into from
Feb 24, 2025

Conversation

kloubere
Copy link

@kloubere kloubere commented Feb 11, 2025 •
edited by FlorentP42
Loading

Should be merged before #110

@kloubere kloubere force-pushed the PMP2-378-GI_EXP_PART branch from 4f72972 to 2c5408b Compare February 11, 2025 14:44
@kloubere
Copy link
Author

Pull request that resolves PMP2-378.
This issue is about sending a GI interogation after receiving a TSCE that contains a "trigger_south_gi" in their "pivot_subtypes" json configuration.
This PR contains the code, the unit tests for the configuration and the functional tests for the plugin itself.

@FlorentP42 FlorentP42 changed the base branch from main to develop-PMC-2.2 February 14, 2025 16:15
@kloubere kloubere force-pushed the PMP2-378-GI_EXP_PART branch from 43494d9 to cfc4070 Compare February 14, 2025 16:46
LOUBERE Kevin and others added 7 commits February 14, 2025 17:50
refs #PMP2-378 Add code to store triggering GI TS addresses in hnzcon…
c71c17d 
…f, and use it in plugin

Signed-off-by: LOUBERE Kevin <[email protected]>
refs #PMP2-378 Create HNZ conf unit tests
a5c3f61 
Signed-off-by: LOUBERE Kevin <[email protected]>
refs #PMP2-378 Create HNF plugin functionnal tests
e10c290 
Signed-off-by: LOUBERE Kevin <[email protected]>
refs #PMP2-378 Adapt code and tests to handle only 0 value TS
6e99cc8 
Signed-off-by: LOUBERE Kevin <[email protected]>
refs #PMP2-378 Correct SonarQube code analysis
6fafd45 
Signed-off-by: LOUBERE Kevin <[email protected]>
refs #PMP2-378 Added const variables for all HNZ protocol key frame v…
d554071 
…alues.

Signed-off-by: Florent Peyrusse <[email protected]>
refs #PMP2-378 Added const variables for all HNZ protocol key frame v…
a4ce57a 
…alues part 2 + post merge fixes.

Signed-off-by: Florent Peyrusse <[email protected]>
@kloubere kloubere force-pushed the PMP2-378-GI_EXP_PART branch from cfc4070 to a4ce57a Compare February 14, 2025 16:51
@FlorentP42 FlorentP42 marked this pull request as ready for review February 17, 2025 09:16
@FlorentP42 FlorentP42 mentioned this pull request Feb 17, 2025
Open
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
60.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Ineo-JFA Ineo-JFA requested review from Aeredren and YmaIneo February 24, 2025 09:25
@YmaIneo YmaIneo merged commit de18329 into develop-PMC-2.2 Feb 24, 2025
3 of 4 checks passed
@YmaIneo YmaIneo deleted the PMP2-378-GI_EXP_PART branch February 24, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YmaIneo YmaIneo YmaIneo approved these changes

@Aeredren Aeredren Awaiting requested review from Aeredren

Assignees

@YmaIneo YmaIneo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kloubere @YmaIneo