You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadly the global coverage is quite low due to this issue with branch coverage that cannot really be solved unless we change the tools we are working with: https://stackoverflow.com/questions/42003783/lcov-gcov-branch-coverage-with-c-producing-branches-all-over-the-place
About duplication it appears to be related to already existing blocks of "duplicated" code (very similar but not totally equal) that were slightly modified during this ticket, not sure how we should treat those cases. EDIT: After discussing it internally, I will refactor the code to avoid this duplication.
* Removed all messages waiting to be sent to the HNZ device when connection is lost.
* Ensured that no message received addressed to the HNZ device while connection is not established will be buffered.
* Improved log messages displayed when an information message is rejected.
* Added unit test for this new behavior.
Signed-off-by: Florent Peyrusse <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlorentP42
commented
FlorentP42
force-pushed
the
PMP2-278-Remove-TC-bufferisation
branch
from
