Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 remove duplicate dependency for esbuild #12

Merged
merged 5 commits into from
Jul 12, 2024

Conversation

heldrida
Copy link
Member

Why?

Remove duplicate dependency for esbuild.

How?

  • Remove esbuild from devDependencies as its required as a dependency, e.g. functions bundling

Tickets?

Contribution checklist?

  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content are linked and stored in the project
  • You have manually tested
  • You have provided tests

Security checklist?

  • Sensitive data has been identified and is being protected properly
  • Injection has been prevented (parameterized queries, no eval or system calls)

Preview?

Screenshot 2024-07-11 at 10 02 03

Copy link

changeset-bot bot commented Jul 11, 2024

🦋 Changeset detected

Latest commit: 3c979a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@fleek-platform/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kkudryaev
kkudryaev previously approved these changes Jul 11, 2024
gabrielmpinto
gabrielmpinto previously approved these changes Jul 11, 2024
@heldrida heldrida dismissed stale reviews from gabrielmpinto and kkudryaev via f4b3cdc July 12, 2024 09:32
@heldrida heldrida force-pushed the chore/remove-duplicate-dependency-for-esbuild branch from 6273436 to f4b3cdc Compare July 12, 2024 09:32
@heldrida heldrida force-pushed the chore/remove-duplicate-dependency-for-esbuild branch from f4b3cdc to 3c979a3 Compare July 12, 2024 09:41
@heldrida heldrida merged commit fa97a4e into develop Jul 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants