move deferred function to avoid calling it if we don't need to

fleetdm · Mar 6, 2025 · 8323712 · 8323712
1 parent e5059f5
commit 8323712
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/server/vulnerabilities/nvd/cpe.go b/server/vulnerabilities/nvd/cpe.go
@@ -370,13 +370,13 @@ var (
 )
 
 func mutateSoftware(software *fleet.Software, logger log.Logger) {
-	defer func() {
-		if r := recover(); r != nil {
-			level.Warn(logger).Log("msg", "panic during software mutation", "softwareName", software.Name, "softwareVersion", software.Version, "error", r)
-		}
-	}()
 	for _, transformer := range softwareTransformers {
 		if transformer.matches(software) {
+			defer func() {
+				if r := recover(); r != nil {
+					level.Warn(logger).Log("msg", "panic during software mutation", "softwareName", software.Name, "softwareVersion", software.Version, "error", r)
+				}
+			}()
 			transformer.mutate(software, logger)
 			break
 		}