Skip to content

Commit

Permalink
UI - Fix team admin ability to edit MFA (#26002)
Browse files Browse the repository at this point in the history
## For #25956 

- include the `mfa_enabled` field when rendering the edit user modal
- Include `mfa_enabled` as a changeable field in the form submission
logic


![ezgif-119080b112463](https://github.com/user-attachments/assets/83baafff-d7ec-4732-a5c0-c1878965d8ce)

- [x] Changes file added for user-visible changes in `changes/`
- [x] A detailed QA plan exists on the associated ticket (if it isn't
there, work with the product group's QA engineer to add it)
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <[email protected]>
  • Loading branch information
jacobshandling and Jacob Shandling authored Feb 4, 2025
1 parent de58010 commit ee47556
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions changes/25956-fix-buggy-efa-editing
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix a bug where team admins are unable to enable or disable MFA for a user
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ const enhanceUsersData = (
role: generateRole(teamId, user.teams),
teams: user.teams,
sso_enabled: user.sso_enabled,
mfa_enabled: user.mfa_enabled,
global_role: user.global_role,
actions: generateActionDropdownOptions(),
id: user.id,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ const generateUpdateData = (
"name",
"email",
"sso_enabled",
"mfa_enabled",
];
return Object.keys(formData).reduce<IUserUpdateBody | any>(
(updatedAttributes, attr) => {
Expand Down

0 comments on commit ee47556

Please sign in to comment.