Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API / YAML changes] Deploy SCEP certificates from custom certificate authority #26484

Merged
merged 25 commits into from
Mar 3, 2025

Conversation

marko-lisica
Copy link
Member

@marko-lisica marko-lisica commented Feb 20, 2025

Related to:

There are few small updates on top of this PR in this one: #26802

@marko-lisica marko-lisica changed the title Add integrations.scep_proxy config [API design] Deploy SCEP certificates from custom certificate authority Feb 20, 2025
@marko-lisica marko-lisica changed the title [API design] Deploy SCEP certificates from custom certificate authority [API / YAML changes] Deploy SCEP certificates from custom certificate authority Feb 20, 2025
@marko-lisica marko-lisica marked this pull request as ready for review February 20, 2025 14:29
@marko-lisica marko-lisica added the ~api-or-yaml-design Used for pull requests (PRs) with proposed API and YAML changes label Feb 20, 2025
@marko-lisica marko-lisica merged commit 8d0c784 into docs-v4.66.0 Mar 3, 2025
5 checks passed
@marko-lisica marko-lisica deleted the 25822-api-changes branch March 3, 2025 12:25
@@ -1544,6 +1544,97 @@ Generated when NDES SCEP proxy configuration is edited in Fleet.

This activity does not contain any detail fields.

## added_custom_scep_proxy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marko-lisica This should be added_scep_proxy to be consistent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@getvictor We changed scep_proxy naming in all other places in API to custom_scep_proxy.

api_token: $DIGICERT_API_TOKEN
profile_id: 926dbcdd-41c4-4fe5-96c3-b6a7f0da81d8
certificate_common_name: [email protected]
certificate_subject_alternative_name: [email protected]
Copy link
Member Author

@marko-lisica marko-lisica Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev note:

@getvictor Name is changed, it should be certificate_user_principal_names instead certificate_subject_alternative_name

It should be an array of names:

digicert:
  certificate_user_principal_names:
  - [email protected]
  - [email protected]

I'll do a separate PR to merge this to docs-v4.66.0.

Error if user adds more than one certificate_user_principal_names for now.

Error: Couldn’t edit integrations.digicert. Currently, only one item can be added to `certificate_user_principal_names`.  

"api_token": "********",
"profile_id": "7ed77396-9186-4bfa-9fa7-63dddc46b8a3",
"certificate_common_name": "[email protected]",
"certificate_subject_alternative_name": "[email protected]",
Copy link
Member Author

@marko-lisica marko-lisica Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev note:

@getvictor Name is changed, it should be certificate_user_principal_names instead certificate_subject_alternative_name

It should be an array of names:

"digicert": [
  {
    "certificate_user_principal_names": [
      "[email protected]",
      "[email protected]"
    ]
  }
]

I'll do a separate PR to merge this to docs-v4.66.0.

Error if user adds more than one certificate_user_principal_names for now.

Error: Couldn’t edit certificate authority. Currently, only one item can be added to `certificate_user_principal_names`.

marko-lisica added a commit that referenced this pull request Mar 4, 2025
…certificate authority

Related to: 
- #25822

Main API design PR is already merged. This PR updates few smaller things (naming mostly).
Main PR: #26484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~api-or-yaml-design Used for pull requests (PRs) with proposed API and YAML changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants