-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API / YAML changes] Deploy SCEP certificates from custom certificate authority #26484
Conversation
integrations.scep_proxy
config…icate authorities guide URL
Co-authored-by: Noah Talerman <[email protected]>
Co-authored-by: Noah Talerman <[email protected]>
Co-authored-by: Noah Talerman <[email protected]>
Co-authored-by: Noah Talerman <[email protected]>
…nd custom scep, added URL field to digicert
@@ -1544,6 +1544,97 @@ Generated when NDES SCEP proxy configuration is edited in Fleet. | |||
|
|||
This activity does not contain any detail fields. | |||
|
|||
## added_custom_scep_proxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marko-lisica This should be added_scep_proxy
to be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@getvictor We changed scep_proxy
naming in all other places in API to custom_scep_proxy
.
api_token: $DIGICERT_API_TOKEN | ||
profile_id: 926dbcdd-41c4-4fe5-96c3-b6a7f0da81d8 | ||
certificate_common_name: [email protected] | ||
certificate_subject_alternative_name: [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev note:
@getvictor Name is changed, it should be certificate_user_principal_names
instead certificate_subject_alternative_name
It should be an array of names:
digicert:
certificate_user_principal_names:
- [email protected]
- [email protected]
I'll do a separate PR to merge this to docs-v4.66.0
.
Error if user adds more than one certificate_user_principal_names
for now.
Error: Couldn’t edit integrations.digicert. Currently, only one item can be added to `certificate_user_principal_names`.
"api_token": "********", | ||
"profile_id": "7ed77396-9186-4bfa-9fa7-63dddc46b8a3", | ||
"certificate_common_name": "[email protected]", | ||
"certificate_subject_alternative_name": "[email protected]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev note:
@getvictor Name is changed, it should be certificate_user_principal_names
instead certificate_subject_alternative_name
It should be an array of names:
"digicert": [
{
"certificate_user_principal_names": [
"[email protected]",
"[email protected]"
]
}
]
I'll do a separate PR to merge this to docs-v4.66.0
.
Error if user adds more than one certificate_user_principal_names
for now.
Error: Couldn’t edit certificate authority. Currently, only one item can be added to `certificate_user_principal_names`.
Related to:
There are few small updates on top of this PR in this one: #26802