Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YAML design] Update/patch software: install if it's below a minimum version #26766

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[YAML design] Update/patch software: install if it's below a minimum version #26766

wants to merge 5 commits into from
+16 −0

Conversation

eugkuo
Copy link
Contributor

@eugkuo eugkuo commented Mar 3, 2025 •
edited by noahtalerman
Loading

YAML changes for the following user story:

@eugkuo
Update yaml-files.md
722e89a 
Adding ability to auto-install and to update apps.
@eugkuo eugkuo requested a review from rachaelshaw as a code owner March 3, 2025 17:39
eugkuo
eugkuo commented Mar 3, 2025
View reviewed changes
docs/Configuration/yaml-files.md
@@ -343,15 +343,23 @@ software:
labels_include_any:
- Engineering
- Customer Support
ensure: present
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev note. If the user enters something other than 'present':

Error: Couldn’t ensure entered state. Currently, only ‘present’ is supported.

@eugkuo

This comment was marked as resolved.

Sign in to view
@eugkuo eugkuo mentioned this pull request Mar 3, 2025
Open
19 tasks
eugkuo
eugkuo commented Mar 3, 2025
View reviewed changes
docs/Configuration/yaml-files.md
@@ -343,15 +343,20 @@ software:
labels_include_any:
- Engineering
- Customer Support
ensure: present
minimum_version: '1.2.3'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev note. If user enters a non-semantic version

Error: Couldn’t ensure entered state. Currently, ‘minimum_version’ must be a semantic version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev note. If user defines a min version greater than the app version, show error:

The minimum version entered is greater than the software’s version, which would cause an infinite install loop. Please enter a new minimum version.

@noahtalerman
Copy link
Member

Hey @eugkuo, just a reminder to update the title of YAML/API design PRs to use "[YAML design] user story name" format and added the ~api-or-yaml-design label to Rachael can easily recognize the PR as YAML design, to prioritize it's review, and know which story the changes are for.

I did it here and in your API PR here: #26778

@noahtalerman noahtalerman changed the title Update yaml-files.md [YAML design] Update/patch software: install if it's below a minimum version Mar 4, 2025
@rachaelshaw rachaelshaw added the ~api-or-yaml-design Used for pull requests (PRs) with proposed API and YAML changes label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fleet-release fleet-release fleet-release approved these changes

@rachaelshaw rachaelshaw Awaiting requested review from rachaelshaw rachaelshaw is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
~api-or-yaml-design Used for pull requests (PRs) with proposed API and YAML changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eugkuo @noahtalerman @fleet-release @rachaelshaw