Clarify GitOps user permissions to modify gitops org settings
#26790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify GitOps user permissions to modify `gitops` org settings
fleet-release
approved these changes
Mar 3, 2025
rachaelshaw
requested review from
noahtalerman
and removed request for
Drew-P-drawers
This was referenced Mar 3, 2025
Drew-P-drawers
approved these changes
Mar 3, 2025
noahtalerman
reviewed
Mar 4, 2025
| @@ -105,6 +105,8 @@ GitOps is an API-only and write-only role that can be used on CI/CD pipelines. | |||
|
|
|||
| \** Applies only to [Fleet REST API](https://fleetdm.com/docs/using-fleet/rest-api) | |||
|
|
|||
| \*** GitOps users do not have access to modify `gitops` settings. | |||
There was a problem hiding this comment.
Hey @rachaelshaw as someone looking at this for the first time (new user), I'm not sure I understand what "gitops settings means". This is about editing GitOps mode right? Maybe we add a new "Edit GitOps mode" row to the table?
That said, I thought we weren't adding any permissions changes as part of the user story. Did that change?
There was a problem hiding this comment.
@noahtalerman ah I see what you mean, we should still allow the GitOps role to modify GitOps mode org settings (if someone wanted to do that via the API for some reason), but just not allow it to be updated via YAML. I was conflating the GitOps role with the fleetctl gitops command in my mind.
I'll close this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #26743